Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Luckfox Core3566 #7354

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Support for Luckfox Core3566 #7354

merged 1 commit into from
Oct 9, 2024

Conversation

buldo
Copy link
Contributor

@buldo buldo commented Oct 8, 2024

Description

Adding support for new board - Luckfox Core3566.
PR includes config file and u-boot patch.
DTS files for kernel was merged in armbian/linux-rockchip#254

Related to #7295

How Has This Been Tested?

I have board version wirthout emmc and wifi.

  • Board booting
  • HDMI works
  • Ethernet works

Checklist:

have no idea that should be checked for next list

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@buldo buldo requested a review from igorpecovnik as a code owner October 8, 2024 21:27
@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Oct 8, 2024
@buldo buldo mentioned this pull request Oct 8, 2024
Closed
1 task
@SuperKali SuperKali added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Oct 9, 2024
igorpecovnik
igorpecovnik approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Oct 9, 2024
@igorpecovnik igorpecovnik merged commit e765a31 into armbian:main Oct 9, 2024
@ceccocats
Copy link

Tested on my core3566:

  • booted from emmc and sd
  • wifi works
  • HDMI works
  • USB don't work

I have a bad error on dmesg near second 10:
dmesg.txt

@SuperKali
Copy link
Member

@ceccocats you've to check the DTS to fix the problem:

[   10.121467] rockchip-vop2 fe040000.vop: [drm:vop2_bind] vp1 assign plane mask: [0x0], primary plane phy id: (null)[-1]
[   10.121581] ------------[ cut here ]------------
[   10.121592] WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:13762 vop2_bind+0xe24/0x24c4
[   10.121621] Modules linked in:
[   10.121637] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G        W          6.1.75-vendor-rk35xx #1
[   10.121653] Hardware name: luckfox,core3566 (DT)
[   10.121663] pstate: a0400009 (NzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   10.121680] pc : vop2_bind+0xe24/0x24c4
[   10.121696] lr : vop2_bind+0xe10/0x24c4
[   10.121711] sp : ffff80000a64b810
[   10.121719] x29: ffff80000a64b810 x28: 0000000000000000 x27: ffff000006496480
[   10.121745] x26: 0000000000000002 x25: ffff000006514080 x24: ffff8000097b13e9
[   10.121770] x23: ffff000006515080 x22: ffff80000936f068 x21: ffff00000104a810
[   10.121794] x20: ffff00000651300c x19: ffff000006510080 x18: 000000000000002d
[   10.121819] x17: 73616d20656e616c x16: 0000000000001350 x15: 20317076205d646e
[   10.121843] x14: 69625f32706f763a x13: 5d312d5b296c6c75 x12: 6e28203a64692079
[   10.121868] x11: 687020656e616c70 x10: 207972616d697270 x9 : 0000000000000000
[   10.121892] x8 : ffff000006496500 x7 : ffff80000a4c0fa0 x6 : 000000000000003f
[   10.121916] x5 : 0000000000000000 x4 : ffffffffffffffff x3 : 0000000000000001
[   10.121940] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffffffffffffffff
[   10.121965] Call trace:
[   10.121974]  vop2_bind+0xe24/0x24c4
[   10.121993]  component_bind_all+0x158/0x234
[   10.122017]  rockchip_drm_bind+0x38c/0x82c
[   10.122037]  try_to_bring_up_aggregate_device+0x9c/0x274
[   10.122057]  component_master_add_with_match+0xd8/0xfc
[   10.122076]  rockchip_drm_platform_probe+0x26c/0x2a4
[   10.122094]  platform_probe+0x70/0xc0
[   10.122111]  really_probe+0x1cc/0x390
[   10.122130]  __driver_probe_device+0x140/0x158
[   10.122148]  driver_probe_device+0x48/0xd0
[   10.122166]  __driver_attach+0xbc/0x17c
[   10.122183]  bus_for_each_dev+0x78/0xc4
[   10.122199]  driver_attach+0x2c/0x38
[   10.122216]  bus_add_driver+0xf8/0x20c
[   10.122233]  driver_register+0xbc/0xf8
[   10.122247]  __platform_driver_register+0x30/0x3c
[   10.122262]  rockchip_drm_init+0xe8/0x124
[   10.122282]  do_one_initcall+0x94/0x1e4
[   10.122299]  kernel_init_freeable+0x2e8/0x2f0
[   10.122319]  kernel_init+0x30/0x138
[   10.122337]  ret_from_fork+0x10/0x20
[   10.122354]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@buldo @ceccocats @SuperKali @igorpecovnik